Form Factory’s standards for creating and managing pull requests. Companion to code-review-guidelines, which covers the review side of the process. The emphasis is on author ownership — authors are responsible for ensuring PRs meet requirements, get reviewed, and merge on time.
PR Requirements
All of the following must be met before marking a PR as “Ready for Review”:
- Clear title — descriptive and concise; the title becomes part of release notes
- Clear description — summary of changes, linked tickets, QA testing steps if applicable
- CI/CD passing — all workflows green
- No conflicts with main — rebase frequently
- Size limit — enforced by CI:
| Lines Changed | Status |
|---|---|
| ≤ 200 | Ideal |
| 200–500 | Warning |
| > 500 | Hard stop (CI fails) |
Why Small PRs Matter
- Reviewed and merged significantly faster
- Fewer bugs, faster launches
- Easier to share context with reviewers
Size Limit Exceptions
- Proactively contact project leads
- Include justification in the PR description
- Valid example: copying well-tested code from an official template
Merging
A PR can be merged once:
- At least one code owner has approved
- All comments are resolved
- All PR requirements are met
The author owns the merge timeline — do not wait passively for others to unblock your work. See code-review-guidelines for the full review workflow including escalation steps.